Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TST: parametrize and de-duplicate arithmetic tests #23240

Merged
merged 8 commits into from
Oct 24, 2018
Merged

TST: parametrize and de-duplicate arithmetic tests #23240

merged 8 commits into from
Oct 24, 2018

Conversation

jbrockmendel
Copy link
Member

This is likely to be a sisyphean task...

@pep8speaks
Copy link

Hello @jbrockmendel! Thanks for submitting the PR.

jbrockmendel
jbrockmendel commented Oct 19, 2018
View reviewed changes
pandas/tests/arithmetic/test_datetime64.py

def test_dti_radd_timestamp_raises(self):
idx = DatetimeIndex(['2011-01-01', '2011-01-02'])
msg = "cannot add DatetimeIndex and Timestamp"
with tm.assert_raises_regex(TypeError, msg):
Timestamp('2011-01-01') + idx
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decided that separating tests for __add__ vs __radd__ was overkill.

@codecov
Copy link

codecov bot commented Oct 20, 2018 •
edited
Loading

Codecov Report

Merging #23240 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #23240      +/-   ##
==========================================
+ Coverage   92.22%   92.22%   +<.01%     
==========================================
  Files         169      169              
  Lines       50897    50899       +2     
==========================================
+ Hits        46940    46942       +2     
  Misses       3957     3957
Flag Coverage Δ
#multiple 90.65% <100%> (ø) ⬆️
#single 42.29% <0%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/util/testing.py 86.53% <100%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a0c91e...699144b. Read the comment docs.

@jbrockmendel jbrockmendel mentioned this pull request Oct 20, 2018
Merged
@jreback jreback added the Testing pandas testing functions or related to the test suite label Oct 23, 2018
@jreback jreback added this to the 0.24.0 milestone Oct 23, 2018
@jreback
Copy link
Contributor

jreback commented Oct 23, 2018

looks ok. can you merge master, and does this need to go before #22862 ?

@jbrockmendel
Copy link
Member Author

can you merge master, and does this need to go before #22862 ?

Just pushed. 22862 is PeriodArray, maybe you meant #23215? Should be fine either way.

@jbrockmendel jbrockmendel mentioned this pull request Oct 24, 2018
Closed
@jreback jreback merged commit 4eaaf36 into pandas-dev:master Oct 24, 2018
@jreback
Copy link
Contributor

jreback commented Oct 24, 2018

thanks!

@jbrockmendel jbrockmendel deleted the mtests2 branch October 24, 2018 16:09
tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018
@jbrockmendel @tm9k1
TST: parametrize and de-duplicate arithmetic tests (pandas-dev#23240)
614e596
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@jbrockmendel @Pingviinituutti
TST: parametrize and de-duplicate arithmetic tests (pandas-dev#23240)
53dc657
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockmendel @pep8speaks @jreback